Source that flattens a task source and keeps the materialized value #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelhamed
force-pushed
the
task-source-22360
branch
2 times, most recently
from
09ede26
to
1fcba5b
Compare
ismaelhamed
force-pushed
the
task-source-22360
branch
from
1fcba5b
to
d5e9278
Compare
|
Looks like unrelated tests failing... |
The bane of my existence... |
Aaronontheweb
approved these changes
Oct 24, 2021
| @@ -916,7 +916,8 @@ namespace Akka.Streams | |||
| } | |||
| public class StreamDetachedException : System.Exception | |||
| { | |||
| public static readonly Akka.Streams.StreamDetachedException Instance; | |||
There was a problem hiding this comment.
Bit of a breaking change here - should probably keep this member but also allow the public constructor.
There was a problem hiding this comment.
@Aaronontheweb should I send a new PR and add this back?
| @@ -1946,6 +1947,7 @@ namespace Akka.Streams.Dsl | |||
| public static Akka.Streams.Dsl.Source<T, Akka.NotUsed> FromObservable<T>(System.IObservable<T> observable, int maxBufferCapacity = 128, Akka.Streams.OverflowStrategy overflowStrategy = 2) { } | |||
| public static Akka.Streams.Dsl.Source<T, Akka.NotUsed> FromPublisher<T>(Reactive.Streams.IPublisher<T> publisher) { } | |||
| public static Akka.Streams.Dsl.Source<T, Akka.NotUsed> FromTask<T>(System.Threading.Tasks.Task<T> task) { } | |||
| public static Akka.Streams.Dsl.Source<T, System.Threading.Tasks.Task<M>> FromTaskSource<T, M>(System.Threading.Tasks.Task<Akka.Streams.Dsl.Source<T, M>> task) { } | |||
| // should complete as soon as inner source has been materialized | ||
| sourceMatVal.Result.Should().Be("foo"); | ||
| sinkMatVal.Result.Should().BeEquivalentTo(ImmutableList.CreateRange(new List<int>() { 1, 2, 3 })); | ||
| }, _materializer); |
This was referenced Nov 10, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of
FromFutureSourceoperator