Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LightningDB reference in cluster sharding, make ddata non-durable as default #5175

Merged
merged 4 commits into from
Aug 6, 2021
Merged

Remove LightningDB reference in cluster sharding, make ddata non-durable as default #5175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4c87b7
Remove LightningDB reference in cluster sharding, make ddata non-dura…
Arkatufus Aug 6, 2021
1761a27
Merge branch 'dev' into Fix_ClusterSharding_default_DData_state
Arkatufus Aug 6, 2021
43f9c4a
Merge branch 'dev' into Fix_ClusterSharding_default_DData_state
Aaronontheweb Aug 6, 2021
85f1e68
Add durable keys config to cluster sharding DData spec
Arkatufus Aug 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .../Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingRememberEntitiesNewExtractorSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ class = ""Akka.Cluster.Sharding.Tests.MemoryJournalShared, Akka.Cluster.Sharding
timeout = 5s
}}
akka.cluster.sharding.state-store-mode = ""{mode}""
akka.cluster.sharding.distributed-data.durable.keys = [""shard-*""]
akka.cluster.sharding.distributed-data.durable.lmdb {{
dir = ""target/ClusterShardingMinMembersSpec/sharding-ddata""
map-size = 10000000
Expand Down
1 change: 1 addition & 0 deletions ...trib/cluster/Akka.Cluster.Sharding.Tests.MultiNode/ClusterShardingRememberEntitiesSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class = ""Akka.Cluster.Sharding.Tests.MemoryJournalShared, Akka.Cluster.Sharding
timeout = 5s
}}
akka.cluster.sharding.state-store-mode = ""{mode}""
akka.cluster.sharding.distributed-data.durable.keys = [""shard-*""]
akka.cluster.sharding.distributed-data.durable.lmdb {{
dir = ""target/ClusterShardingMinMembersSpec/sharding-ddata""
map-size = 10000000
Expand Down
2 changes: 2 additions & 0 deletions src/contrib/cluster/Akka.Cluster.Sharding.Tests/ClusterShardingConfigSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ public void Should_cluster_sharding_settings_have_default_config()
Assert.Equal(string.Empty, singletonConfig.GetString("role"));
Assert.Equal(TimeSpan.FromSeconds(1), singletonConfig.GetTimeSpan("hand-over-retry-interval"));
Assert.Equal(15, singletonConfig.GetInt("min-number-of-hand-over-retries"));

Assert.Empty(config.GetStringList("distributed-data.durable.keys"));
}
}
}
1 change: 0 additions & 1 deletion src/contrib/cluster/Akka.Cluster.Sharding/Akka.Cluster.Sharding.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<ProjectReference Include="..\..\..\core\Akka.Coordination\Akka.Coordination.csproj" />
<ProjectReference Include="..\..\..\core\Akka.Persistence\Akka.Persistence.csproj" />
<ProjectReference Include="..\Akka.Cluster.Tools\Akka.Cluster.Tools.csproj" />
<ProjectReference Include="..\Akka.DistributedData.LightningDB\Akka.DistributedData.LightningDB.csproj" />
<ProjectReference Include="..\Akka.DistributedData\Akka.DistributedData.csproj" />
</ItemGroup>

Expand Down
6 changes: 4 additions & 2 deletions src/contrib/cluster/Akka.Cluster.Sharding/reference.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,10 @@ akka.cluster.sharding {
distributed-data {
# minCap parameter to MajorityWrite and MajorityRead consistency level.
majority-min-cap = 5

durable.keys = ["shard-*"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you recall why we added this in the first place?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was in the official JVM reference.conf, I didn't know that our default value is different than theirs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it seems that our issue really comes down to the .NET LightningDb packages not having all of the native dependencies they need. We'll add this setting back when we move the default for Akka.Cluster.Sharding state store mode away from persistence and to DData.


# Uncomment this line if you want to use the durable version of DData and make sure that
# you also reference the Akka.DistributedData.LightningDB nuget package.
# durable.keys = ["shard-*"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure we tell users to add this setting back in the documentation (in the other PR you're working on)


# When using many entities with "remember entities" the Gossip message
# can become to large if including to many in same message. Limit to
Expand Down