-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A couple of fixes affecting the FileSubscriber #5035
Conversation
5ccbc66
to
03338fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -2564,6 +2564,11 @@ namespace Akka.Streams.Extra | |||
} | |||
namespace Akka.Streams.IO | |||
{ | |||
public sealed class AbruptIOTerminationException : System.Exception |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
var ex = Intercept<AbruptIOTerminationException>(() => completion.Wait(TimeSpan.FromSeconds(3))); | ||
ex.IoResult.Count.ShouldBe(1001); | ||
CheckFileContent(f, string.Join("", _testLines.TakeWhile(s => !s.Contains('b')))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
var completion = Source.Failed<ByteString>(new Exception("Boom!")) | ||
.RunWith(StreamConverters.FromOutputStream(() => new OutputStream()), _materializer); | ||
|
||
AssertThrows<AbruptIOTerminationException>(completion.Wait); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ports of #24577 and #25089