Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ActorPath.ToString call from ResolveActorRefWithLocalAddress #5034

Merged

Conversation

Aaronontheweb
Copy link
Member

Provided that this works, should eliminate an entire source of allocations from the Akka.Remote deserialization pipeline.

@Aaronontheweb Aaronontheweb marked this pull request as ready for review May 24, 2021 16:10
@Aaronontheweb
Copy link
Member Author

Great, no test failures - this means we can merge this PR to eliminate the previous hack that has been in place for ~6 years or so. Excellent.

@Aaronontheweb Aaronontheweb added this to the 1.4.21 milestone May 24, 2021
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) May 24, 2021 17:42
@Aaronontheweb Aaronontheweb merged commit 6f5b003 into akkadotnet:dev May 24, 2021
@Aaronontheweb Aaronontheweb deleted the perf/AkkaRemote-allocations branch June 3, 2021 22:41
This was referenced Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants