Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LMDB into release version #4442

Merged
merged 2 commits into from
May 27, 2020

Conversation

Arkatufus
Copy link
Contributor

  • Remove Akka.DistributedData.LightningDB beta status
  • Add reference to Akka.DistributedData.LightningDB in Akka.Cluster.Sharding for easier end user implementation.

@Arkatufus
Copy link
Contributor Author

Any user who needs to access LMDB from outside of Akka.Cluster.Sharding will still need to reference it manually, we can't include LMDB inside Akka.DistributedData unless we move the whole code into it (circular reference issue).
This is actually the case in scala Akka, LMDB is part of the Akka.DistributedData package, instead of its own standalone package.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb added this to the 1.4.7 milestone May 27, 2020
@Aaronontheweb Aaronontheweb added akka-cluster-sharding akka-ddata-durable LMDB implementation for persisting durable data labels May 27, 2020
@Aaronontheweb
Copy link
Member

Any user who needs to access LMDB from outside of Akka.Cluster.Sharding will still need to reference it manually, we can't include LMDB inside Akka.DistributedData unless we move the whole code into it (circular reference issue).
This is actually the case in scala Akka, LMDB is part of the Akka.DistributedData package, instead of its own standalone package.

Should we just do that in a new release in the future? Pretty easy to deprecate packages on NuGet now.

@Aaronontheweb Aaronontheweb merged commit 00e084e into akkadotnet:dev May 27, 2020
@Arkatufus
Copy link
Contributor Author

It should be trivial to do, Akka.DistributedData.LightningDB only contains 1 class file and 1 HOCON configuration file

@Arkatufus Arkatufus deleted the Release_DData_LMDB branch March 8, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-cluster-sharding akka-ddata-durable LMDB implementation for persisting durable data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants