Bug fix #4376 #4393
Merged
Bug fix #4376 #4393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely looks like there's a bug with the supervision code when the parent actor is a pool router. |
Aaronontheweb
requested changes
May 7, 2020
|
|
||
| if (IsTerminated) SendAllToDeadLetters(todo); | ||
| else if (!todo.IsEmpty) SysMsgInvokeAll(todo, newState); |
There was a problem hiding this comment.
IMHO, let's put the while loop back in place so we can save on recursion costs - shouldn't be a big deal either way since system messages are pretty rare but I'd feel more comfortable only changing one thing at a time here.
Aaronontheweb
approved these changes
May 8, 2020
Aaronontheweb
approved these changes
May 8, 2020
Arkatufus
deleted the
#4376_Superviser_failed_to_handle_multiple_children_failure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4376