Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Akka.Cluster.Metrics extension implementation #4126
Akka.Cluster.Metrics extension implementation #4126
Changes from 12 commits
2b7f153
d323eff
29a3264
f6a2ae6
48682e1
4ce8099
71f6381
19ff99a
9a52276
afa8365
33624fc
0f806c6
fe324fb
7f4e983
b42644a
0ef34ed
d6ac8dd
5f078e5
39e5171
a43e76b
a9ec08e
e45c73c
dd84077
e5dcf83
5476934
3ca5bf6
5e24ecf
af5cb25
93b88b1
6606492
cab575e
3087efb
52f04d4
295d699
6825b2d
6da830a
da13922
727220b
b84f86a
f1a044d
f1c5386
a390887
ac4d12e
0fe2955
df32600
079bcac
eb05abc
0572cf4
29950c0
4f7a51e
8ddb1a5
4ef2e8c
27b68e4
454ca47
e6bee49
8fa0fd5
b4f6996
878fe84
18be9ee
57f371e
0223f66
ff70a40
dfea281
22018bb
188e025
ecda6ea
78b0109
98b86da
9a9e1d2
0e1495a
c45c7ec
8318488
55f2ed7
d7f4ae3
7ec40f3
6bfb91d
85c0d28
2c4006c
b78dc52
9e50bef
990d19e
fdd27e1
6afac7e
f7e4432
62f7684
61ef434
36ac347
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this
private
- force users to call theClusterMetrics.Get(ActorSystem)
method so we can guarantee a maximum of oneClusterMetrics
instance per-ActorSystem
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this
internal
since it is used inClusterMetricsExtensionProvider
.