-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Netstandard2.0upgrade #3452
Conversation
Update to xunit 2.3.1 is needed. Already being merged into dev. Will need to be ported into the 1.4 branch as well. #3504 |
The PingPong and Spawnbenchmark projects have some issues. That needs looking at. |
No sure why im not seeing CI pips popping up. But i'd expect tests to run to completion after my last commit. It does so locally at least. |
Updated all netcore occurrences to 2.0
Had to update to netstandard2.0 compat version of FluentAssertions. Massive breaking changes. |
stringcollection extensions are inconsistent apparently
Also: Some notes about stuff we are probably going to run into. https://www.continuousimprover.com/2018/02/fluent-assertions-50-best-unit-test.html#upgrading-tips |
replace AllBeEquivalentOf to BeEquivalentOf
Compile failures |
Incidentally I started on the same thing yesterday. Should have checked whether something was already in progress. For now I'll keep working in my fork at https://github.com/heatonmatthew/akka.net/tree/update-netstandard2.0 but I'm keen to consolidate our efforts. Forgive my ignorance but how best can I work with you in a single fork. |
@heatonmatthew have this completed here: #3668 along with our build system overhaul, but I'm waiting on one final piece that I'm working on right now before I merge it all in. |
akkadotnet#3452. Cleanup of customizations that were required for the pre netstandard2.0 API.
Work in Progress to update everything to netstandard 2.0 and netcore2.0.
First stage was updating TargetFrameworks in all the project files. Which is partly done.
This work will be the enabler for some other improvements we have in mind. Feedback is welcome
Note; Lots of the example projects are still in old style csproj. And could use updating. I might do that in here if it gets in the way. But it might be better to make it a seperate issue. Could be an good for first contributors thingy.