Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Netstandard2.0upgrade #3452

Closed
wants to merge 60 commits into from
Closed

WIP Netstandard2.0upgrade #3452

wants to merge 60 commits into from

Conversation

Danthar
Copy link
Member

@Danthar Danthar commented May 16, 2018

Work in Progress to update everything to netstandard 2.0 and netcore2.0.
First stage was updating TargetFrameworks in all the project files. Which is partly done.

  • Akka Core projects update
  • Contrib projects update
    • Akka.Cluster.x
    • Akka.DistributedData
    • The rest
  • Benchmark projects should also target and run netcore suite
  • Check and verify project dependencies
    • Update XUnit dependencies (needs XUnit core)
    • Update to newtonsoft.json 110.2
    • Update to System.Collections.Immutable 1.5.0
  • Possibly update CI infrastructure (scripts and such)
  • Delete netcorepolyfills, aka, get rid of SerializableAttribute shims
  • ApiApproval project needs updating
  • Example projects needs to directly reference akka projects instead of assemblies, and be .netcore compatible instead of targetting net452. Possibly leave some projects to be net452 on purpose as a canary
    • Fsharp examples needs to be fixed
  • Update akka.Fsharp references to Fsharp.core 4.5.2

This work will be the enabler for some other improvements we have in mind. Feedback is welcome

Note; Lots of the example projects are still in old style csproj. And could use updating. I might do that in here if it gets in the way. But it might be better to make it a seperate issue. Could be an good for first contributors thingy.

@Danthar
Copy link
Member Author

Danthar commented Jun 13, 2018

Update to xunit 2.3.1 is needed. Already being merged into dev. Will need to be ported into the 1.4 branch as well. #3504

@Danthar
Copy link
Member Author

Danthar commented Jun 17, 2018

The PingPong and Spawnbenchmark projects have some issues. That needs looking at.

@Danthar
Copy link
Member Author

Danthar commented Jun 17, 2018

No sure why im not seeing CI pips popping up. But i'd expect tests to run to completion after my last commit. It does so locally at least.

@Danthar
Copy link
Member Author

Danthar commented Jul 14, 2018

Had to update to netstandard2.0 compat version of FluentAssertions. Massive breaking changes.
read it, and weep.
https://github.com/fluentassertions/fluentassertions/releases/tag/5.0.0

@Danthar
Copy link
Member Author

Danthar commented Jul 14, 2018

Also: Some notes about stuff we are probably going to run into. https://www.continuousimprover.com/2018/02/fluent-assertions-50-best-unit-test.html#upgrading-tips

@Aaronontheweb
Copy link
Member

Compile failures

@heatonmatthew
Copy link
Contributor

Incidentally I started on the same thing yesterday. Should have checked whether something was already in progress. For now I'll keep working in my fork at https://github.com/heatonmatthew/akka.net/tree/update-netstandard2.0 but I'm keen to consolidate our efforts.

Forgive my ignorance but how best can I work with you in a single fork.

@Aaronontheweb
Copy link
Member

@heatonmatthew have this completed here: #3668 along with our build system overhaul, but I'm waiting on one final piece that I'm working on right now before I merge it all in.

heatonmatthew pushed a commit to heatonmatthew/akka.net that referenced this pull request May 16, 2019
akkadotnet#3452. Cleanup of customizations that were required for the pre netstandard2.0 API.
@Danthar Danthar deleted the netstandard2.0upgrade branch February 22, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants