External ActorSystem for Testkit event filters. #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// </summary> | ||
| /// <param name="system">Actor system.</param> | ||
| /// <returns>A new instance of <see cref="EventFilterFactory"/>.</returns> | ||
| public EventFilterFactory CreateEventFilter(ActorSystem system) |
There was a problem hiding this comment.
Looks good - so this means that the default EventFilter will still work exactly as expected then. That was the only major thing I wanted to check first.
|
The code changes look fine - but could you please add a spec that verifies that the testkit works for a secondary |
This was referenced Mar 7, 2016
|
ping @akoshelev - did you see my comment above? |
This commit resolves issue described in #1630. EventFilters now can be created for user-defined actor systems, not only TestKit.Sys.
|
@Aaronontheweb Hi, |
Aaronontheweb
added a commit
that referenced
this pull request
Mar 17, 2016
External ActorSystem for Testkit event filters.
|
thanks @akoshelev - I've reviewed it and I think it looks good. Thanks for your contribution. |
This was referenced Apr 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves issue described in #1630. EventFilters now can be
created for user-defined actor systems, not only TestKit.Sys.