API Diff with fixed Approval file #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found a tiny, tiny issue in the |
Aaronontheweb
force-pushed
the
ApproveCoreChanges
branch
from
82a595b
to
b23505a
Compare
Aaronontheweb
force-pushed
the
ApproveCoreChanges
branch
from
b23505a
to
aa1236f
Compare
|
Ok, got this passing now - going to add some docs to getakka.net that explain what to do in the event of a change to a public API since it adds some new steps that developers have to be aware of in order for their builds to pass. |
Aaronontheweb
added a commit
that referenced
this pull request
Jan 13, 2016
API Diff with fixed Approval file
This was referenced Jan 13, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.