Implemented the RegisterOnTermination feature. #1523
Conversation
| /// </summary> | ||
| /// <param name="newValue">The new value</param> | ||
| /// <returns>The current value</returns> | ||
| public T GetAndSet(T newValue) |
There was a problem hiding this comment.
This implementation doesn't seem to be atomic. This operation is basically equivalent of return Interlocked.Exchange(ref atomicValue, newValue). Using [MethodImpl(MethodImplOptions.AggressiveInlining)] also could be valuable.
There was a problem hiding this comment.
Yeah I struggled with this one, thanks for the hint, will update the PR.
There was a problem hiding this comment.
Interlocked.Exchange unfortunately only allows reference types in the generic version.
marcpiechura
force-pushed
the
RegisterOnTermination
branch
from
660bdfe
to
a136b77
Compare
|
Looks great! How does this integrate with the termination hooks for Akka.Remote? Or does this live as a separate system? If the |
|
Sorry, but through my low understanding about Akka.Remote I can't give an appropriate answer. |
|
@Silv3rcircl3 ok, no worries Marc - I'll add that as something for me to investigate |
Implemented the RegisterOnTermination feature.
closes #1519
It also implements some of the tests for #60.