Update FsPickler version used by Akka.FSharp #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the Akka.NET project. |
Aaronontheweb
added a commit
that referenced
this pull request
Aug 5, 2015
Update FsPickler version used by Akka.FSharp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1206
Per the referenced issue, Akka.FSharp is using an old version of FsPickler, which I have updated in this PR. The key change in the FsPickler API was the removal of overloads for
Serialize/Deserializetaking a type as a method parameter; instead it is a generic parameter on the method. I made the few minor changes to account for this, hopefully they are idiomatic/appropriate.I ran the F# tests by hand and they passed. I was also able to use the updated Akka.FSharp.dll in conjunction with Vagabond in an FSI session, which I was unable to do with the existing FsPickler.0.9.11-based version.