Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FsPickler version used by Akka.FSharp #1207

Merged
merged 1 commit into from
Aug 5, 2015
Merged

Update FsPickler version used by Akka.FSharp #1207

merged 1 commit into from
Aug 5, 2015

Conversation

rdavisau
Copy link
Contributor

@rdavisau rdavisau commented Aug 5, 2015

Ref #1206

Per the referenced issue, Akka.FSharp is using an old version of FsPickler, which I have updated in this PR. The key change in the FsPickler API was the removal of overloads for Serialize/Deserialize taking a type as a method parameter; instead it is a generic parameter on the method. I made the few minor changes to account for this, hopefully they are idiomatic/appropriate.

I ran the F# tests by hand and they passed. I was also able to use the updated Akka.FSharp.dll in conjunction with Vagabond in an FSI session, which I was unable to do with the existing FsPickler.0.9.11-based version.

@Aaronontheweb
Copy link
Member

Welcome to the Akka.NET project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants