Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDependencyResolver.GetService<T>() is returning object rather than <T> #5086

Closed
Aaronontheweb opened this issue Jun 10, 2021 · 2 comments · Fixed by #5087
Closed

IDependencyResolver.GetService<T>() is returning object rather than <T> #5086

Aaronontheweb opened this issue Jun 10, 2021 · 2 comments · Fixed by #5087
Assignees
@Aaronontheweb
Labels
akka-dependency-injection Akka.DI-related issues api-change
Milestone
1.4.21

Comments

@Aaronontheweb
Copy link
Member

During upgrading to 1.4.21-beta1 we saw that IDependencyResolver.GetService<T>() is returning object. Is there a specific reason why it is not directly returning <T>?
Now we need to cast it to T before we can use the object.

Originally posted by @wesselkranenborg in #5070 (comment)

We should update the API to change this.
@Aaronontheweb Aaronontheweb added the akka-dependency-injection Akka.DI-related issues label Jun 10, 2021
@Aaronontheweb Aaronontheweb added this to the 1.4.21 milestone Jun 10, 2021
@Aaronontheweb Aaronontheweb self-assigned this Jun 10, 2021
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this issue Jun 10, 2021
@Aaronontheweb
return T from `IDependencyResolver.GetService<T>()
f55b562 
close akkadotnet#5086
@Aaronontheweb Aaronontheweb mentioned this issue Jun 10, 2021
Merged
Arkatufus pushed a commit that referenced this issue Jun 10, 2021
@Aaronontheweb
Return T from `IDependencyResolver.GetService<T>() (#5087)
dfd7925 
Close #5086
@wesselkranenborg
Copy link
Contributor

Thanks for solving this, this will ease the update and saves a lot of casts.

@Aaronontheweb
Copy link
Member Author

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aaronontheweb Aaronontheweb

Labels
akka-dependency-injection Akka.DI-related issues api-change
Projects
None yet
Milestone
1.4.21
Development

Successfully merging a pull request may close this issue.

return T from IDependencyResolver.GetService<T>() Aaronontheweb/akka.net
2 participants
@Aaronontheweb @wesselkranenborg