-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SourceLink and Symbol Packages - are they working for you? #3954
Comments
Version: Akka v1.3.15, v1.4.0-beta2+ Not seeing the SourceLink we added back in 1.3.13 and earlier work out in the wild. Has anyone else been able to get it working? |
I think you need to add a portable PDB file to the NuGet package in order to make it work, but I'm not 100% sure. That's also mentioned on the page you linked. The Akka NuGet packages don't appear to have any pdb files included. Also, the v1.4.0 beta package is the first one to have the required element in its spec. |
@akoker so, we haven't been publishing PDBs correctly then by the sound of it? IIRC we do publish separate symbol packages, but we haven't been pushing those correctly. From our 1.3.15 release build logs:
|
I'll have a look at it tomorrow. At my workplace, I only push Nuget packages to private ProGet servers (with symbols and source), not to the official feed - don't know if that makes a difference. I'll check the build scripts. |
It seems the symbol-package does not get pushed in your log. I've created a simple test-package The interesting bits are: I then packed the package using Which creates both a .nupkg and the corresponding symbol-package (.snupkg) in the same directory. I then pushed the package using only
This will also publish the corresponding snupkg if it is in the same directory. Log output:
Note how https://www.nuget.org/packages/LokerIT.SourceLinkTest offers a download link for the symbols and https://www.nuget.org/packages/Akka does not. In Rider, I set up the NuGet symbol server: And that's about it. I can now step into the I'll check the build.fsx file to see where something goes wrong. |
In our current windows-release template, we are not passing the |
So I've investigated the issue and here's where I'm at.
I'll submit a PR that should make the symbols get auto-pushed to NuGet alongside the main package - obviously I can't test it. BTW: symbols are now served by nuget.org directly and not from symbolsource.org anymore. |
* fix: NuGet symbols not published (akkadotnet#3954) Updates the build script to handle the newer snupkg format. * Update windows-release.yml to use V3 API of nuget.org (akkadotnet#3954)
I had similar problems with lagom-dotnet.
Edit: I can see that the settings I noted above are already contained in And, you only need to push the *.nupkg files. Any matching *.snupkg files in the same folder will automatically be pushed. |
Looks like I can add a step to our FAKE script to verify that SourceLink works, but this is a bit out of date - I think this was for when people used to include the .PDBs inside the NuGet packages directly, rather than shipping a separate symbol package. https://github.com/ctaggart/SourceLink/wiki/FAKE Or am I wrong about that? |
I think we generate normal nugets and ones with symbols, and then publish
them both. But I'd have to check.
Op vr 24 jan. 2020 23:53 schreef Aaron Stannard <[email protected]>:
… Looks like I can add a step to our FAKE script to verify that SourceLink
works, but this is a bit out of date - I think this was for when people
used to include the .PDBs inside the NuGet packages directly, rather than
shipping a separate symbol package.
https://github.com/ctaggart/SourceLink/wiki/FAKE
Or am I wrong about that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3954?email_source=notifications&email_token=AAHQ3FZPJDCS2AHSXSX4BTLQ7NWNJA5CNFSM4I5TRXW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ4KWXQ#issuecomment-578333534>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHQ3F4URCAQ3L5AEPDUWYLQ7NWNJANCNFSM4I5TRXWQ>
.
|
I figured this one out - it's a problem with our FAKE script. Going to fix it now. |
#3953 - @mmisztal1980 working on a repro spec now.
For reasons unknown, source link was letting me see where the error was happening. It may be set up incorrectly or our symbol package publishing may not be working correctly.
Originally posted by @Aaronontheweb in #3943 (comment)
The text was updated successfully, but these errors were encountered: