Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Storage Plugins page looks to have broken code under the Journals section. #3732

Closed
izavala opened this issue Mar 8, 2019 · 1 comment · Fixed by #3787
Closed

The Storage Plugins page looks to have broken code under the Journals section. #3732

izavala opened this issue Mar 8, 2019 · 1 comment · Fixed by #3787
Labels
docs good for first-time contributors

Comments

@izavala
Copy link
Contributor

izavala commented Mar 8, 2019

The Persistance, Storage plugins page looks to have a broken section of code in the configurations example. The block of code shown does not look complete and it seems to be missing the actual configuration code.

Storage plugins page

screenshot 2
@sean-gilliam
Copy link
Member

Nice catch. It looks like some line numbers got shifted around for both the Journals and Snapshot store examples. Looks like shifted by 5 lines. That page can be found here https://github.com/akkadotnet/akka.net/blob/dev/docs/articles/persistence/storage-plugins.md

The journals section looks like it should be changed to ../../../src/core/Akka.Persistence/persistence.conf#L201-L207

and the snapshot store should be changed to
../../../src/core/Akka.Persistence/persistence.conf#L209-L215

@ghost ghost mentioned this issue May 16, 2019
Merged
Aaronontheweb pushed a commit that referenced this issue May 18, 2019
@Aaronontheweb
Update Storage Plugins page Ref Issue #3732 (#3787)
d33d113 
Changed Journals and Snapshot store examples to align them correctly.

Closes #3732
madmonkey pushed a commit to madmonkey/akka.net that referenced this issue Jul 12, 2019
@madmonkey
Update Storage Plugins page Ref Issue akkadotnet#3732 (akkadotnet#3787)
191dede 
Changed Journals and Snapshot store examples to align them correctly.

Closes akkadotnet#3732
Aaronontheweb pushed a commit to Aaronontheweb/akka.net that referenced this issue Jul 26, 2019
@Aaronontheweb
Update Storage Plugins page Ref Issue akkadotnet#3732 (akkadotnet#3787)
3e45848 
Changed Journals and Snapshot store examples to align them correctly.

Closes akkadotnet#3732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs good for first-time contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Storage Plugins page Ref: Issue #3732
2 participants
@sean-gilliam @izavala