Remove secure cookie (#6515)

* Remove secure cookie * Update WireFormats.proto --------- Co-authored-by: Aaron Stannard <[email protected]>
akkadotnet · Mar 15, 2023 · 9707dbe · 9707dbe
1 parent 88c59ca
commit 9707dbe
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 17 deletions.
diff --git a/src/core/Akka.Remote.Tests/Transport/AkkaProtocolSpec.cs b/src/core/Akka.Remote.Tests/Transport/AkkaProtocolSpec.cs
@@ -74,10 +74,6 @@ public AkkaProtocolSpec(ITestOutputHelper helper)
 
                     backoff-interval = 1 s
 
-                    require-cookie = off
-
-                    secure-cookie = ""abcde""
-
                     shutdown-timeout = 5 s
 
                     startup-timeout = 5 s

diff --git a/src/core/Akka.Remote/Configuration/Remote.conf b/src/core/Akka.Remote/Configuration/Remote.conf
@@ -154,17 +154,6 @@ akka {
     # E.g. trusted-selection-paths = ["/user/receptionist", "/user/namingService"]   
     trusted-selection-paths = []
 
-    # Should the remote server require that its peers share the same
-    # secure-cookie (defined in the 'remote' section)? Secure cookies are passed
-    # between during the initial handshake. Connections are refused if the initial
-    # message contains a mismatching cookie or the cookie is missing.
-    require-cookie = off
-
-    # Generate your own with the script availbale in
-    # '$AKKA_HOME/scripts/generate_config_with_secure_cookie.sh' or using
-    # 'akka.util.Crypt.generateSecureCookie'
-    secure-cookie = ""
-
     ### Logging
 
     # If this is "on", Akka will log all inbound messages at DEBUG level,

diff --git a/src/protobuf/WireFormats.proto b/src/protobuf/WireFormats.proto
@@ -82,7 +82,7 @@ message AkkaControlMessage {
 message AkkaHandshakeInfo {
 	AddressData origin = 1;
 	fixed64 uid = 2;
-	string cookie = 3;
+  string cookie = 3; // not used
 }
 
 // Defines the type of the AkkaControlMessage command type
@@ -137,4 +137,4 @@ message TailChoppingPool {
 message RemoteRouterConfig {
   Payload local = 1;
   repeated AddressData nodes = 2;
-}
+}