Skip to content

Commit

Permalink
disabled Akka.Persistence.TCK.Query.ReadJournal_should_deallocate_All…
Browse files Browse the repository at this point in the history
…PersistenceIds_publisher_when_the_last_subscriber_left (#5257)

Not a good test - tightly couples to private implementation details for a given journal, plus it's racy. Better to test the stream stage it uses directly or use Akka.Streams completion semantics to check.
  • Loading branch information
Aaronontheweb authored Sep 6, 2021
1 parent b39bce3 commit 850bdb1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/core/Akka.Persistence.TCK/Query/PersistenceIdsSpec.cs
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ public virtual void ReadJournal_AllPersistenceIds_should_deliver_persistenceId_o
});
}

[Fact]
[Fact(Skip = "Not a good test - tightly couples to private implementation details")]
public virtual async Task ReadJournal_should_deallocate_AllPersistenceIds_publisher_when_the_last_subscriber_left()
{
if (AllocatesAllPersistenceIDsPublisher)
Expand Down

0 comments on commit 850bdb1

Please sign in to comment.