improveme child lookup performance (#5241)

akkadotnet · Sep 2, 2021 · 4c494fe · 4c494fe
1 parent f0c0ebf
commit 4c494fe
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/src/benchmark/Akka.Benchmarks/Actor/GetChildBenchmark.cs b/src/benchmark/Akka.Benchmarks/Actor/GetChildBenchmark.cs
@@ -96,7 +96,7 @@ protected override void OnReceive(object message)
         private ActorWithChild.Get _getMessage = new ActorWithChild.Get("food");
         private ActorWithChild.Create _createMessage = new ActorWithChild.Create("food");
 
-        private ActorCell _cell;
+        private IActorContext _cell;
         private RepointableActorRef _repointableActorRef;
         private LocalActorRef _localActorRef;
         private VirtualPathContainer _virtualPathContainer;
@@ -129,7 +129,7 @@ public async Task Setup()
         [Benchmark]
         public void ResolveChild()
         {
-            _cell.TryGetSingleChild(_getMessage.Name, out var child);
+            _cell.Child(_getMessage.Name);
         }
 
         [Benchmark]

diff --git a/src/core/Akka/Actor/ActorCell.Children.cs b/src/core/Akka/Actor/ActorCell.Children.cs
@@ -265,8 +265,7 @@ protected void SetTerminated()
         {
             get
             {
-                var terminating = ChildrenContainer as TerminatingChildrenContainer;
-                return terminating != null && terminating.Reason is SuspendReason.IWaitingForChildren;
+                return ChildrenContainer is TerminatingChildrenContainer terminating && terminating.Reason is SuspendReason.IWaitingForChildren;
             }
         }
 
@@ -325,8 +324,7 @@ public bool TryGetChildStatsByName(string name, out IChildStats child)   //This
         /// </summary>
         private bool TryGetChildRestartStatsByName(string name, out ChildRestartStats child)
         {
-            IChildStats stats;
-            if (ChildrenContainer.TryGetByName(name, out stats))
+            if (ChildrenContainer.TryGetByName(name, out var stats))
             {
                 child = stats as ChildRestartStats;
                 if (child != null)
@@ -362,6 +360,8 @@ public IInternalActorRef GetSingleChild(string name)
             return TryGetSingleChild(name, out child) ? child : ActorRefs.Nobody;
         }
 
+
+
         /// <summary>
         /// TBD
         /// </summary>

diff --git a/src/core/Akka/Actor/ActorCell.cs b/src/core/Akka/Actor/ActorCell.cs
@@ -241,7 +241,10 @@ public void Init(bool sendSupervise, MailboxType mailboxType)
 
         IActorRef IActorContext.Child(string name)
         {
-            return TryGetSingleChild(name, out var child) ? child : ActorRefs.Nobody;
+            if (TryGetChildStatsByName(name, out var child) && child is ChildRestartStats s)
+                return s.Child;
+
+            return ActorRefs.Nobody;
         }
 
         /// <summary>