Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project restructure + BenchmarkDotNet migration #86

Merged
merged 2 commits into from
Jan 18, 2018

Conversation

Aaronontheweb
Copy link
Member

Restructured the project and junked the old build-system in favor of the standardized one we use in Petabridge's projects, which operates based on an extensible set of conventions we've already been using for years in Akka.NET.

Using this to put an end to the build server issues with all of the .NET versions et al. Going to bump all test projects to .NET Core 2.0 if this still has trouble.

@Horusiath
Copy link
Contributor

Horusiath commented Jan 17, 2018

System.InvalidCastException : [A]System.Collections.Immutable.ImmutableStack1[Hyperion.Tests.Something] cannot be cast to [B]System.Collections.Immutable.ImmutableStack1[Hyperion.Tests.Something]. Type A originates from 'System.Collections.Immutable, Version=1.2.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' in the context 'Default' at location 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\1.1.2\System.Collections.Immutable.dll'. Type B originates from 'System.Collections.Immutable, Version=1.2.2.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' in the context 'Default' at location 'C:\Windows\system32\config\systemprofile.nuget\packages\system.collections.immutable\1.4.0\lib\netstandard1.0\System.Collections.Immutable.dll'.

Immutable collections failure log suggests that the issue may be in version of System.Collections.Immutable used. Possibly binding redirects are necessary.

@Aaronontheweb
Copy link
Member Author

@Horusiath I was afraid of that. I'll get the Mono stuff fixed first. Bumping the runtime to .NET Core 2.0 across the board for unit tests should do the trick.

@Aaronontheweb
Copy link
Member Author

@Horusiath fixed that issue. The Tests.csproj didn't actually import the common.props file we use for setting things like the XUnit version. Working on getting the .NET CLI to play nice on Mono now. Looks like it's getting hung up on compiling the F# project.

@Aaronontheweb
Copy link
Member Author

This issue, specifically: dotnet/msbuild#2275

Appears to be a / vs \ difference between Linux and Windows that is causing the problem :p

@Aaronontheweb
Copy link
Member Author

Have all Mono tests and compilation passing now... Working on getting .NET Core to play nice too on Linux.

@Aaronontheweb
Copy link
Member Author

ok, have .NET Core running on Linux now too. Everything should be working. Going to rebase.

@Horusiath Horusiath merged commit 4d2d2a1 into akkadotnet:dev Jan 18, 2018
@Aaronontheweb Aaronontheweb deleted the project-restructure branch January 18, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants