Add custom AggregateException serializer. #266
Conversation
|
|
||
| namespace Hyperion.SerializerFactories | ||
| { | ||
| internal sealed class AggregateExceptionSerializerFactory : ValueSerializerFactory |
There was a problem hiding this comment.
Does the default ExceptionSerializerFactory not handle InnerExceptions? Or is this different because AggregateException can store multiple errors at each layer?
There was a problem hiding this comment.
Regular exceptions have InnerException, AggregateException have InnerException and InnerExceptions
|
@Arkatufus looks like |
| info.AddValue("ExceptionMethod", stream.ReadString(session), typeof (string)); | ||
| info.AddValue("HResult", stream.ReadInt32(session)); | ||
| info.AddValue("Source", stream.ReadString(session), typeof (string)); | ||
| info.AddValue("WatsonBuckets", stream.ReadLengthEncodedByteArray(session), typeof (byte[])); |
There was a problem hiding this comment.
Looks like this is what's causing the Linux specs to barf
There was a problem hiding this comment.
Yeah, I guess we need to drop it.
…rkatufus/Hyperion into #265_Add_AggregateException_serializer
|
This serializer would not be available in .NET Standard 1.6 |
|
Do we have to support this property or can we elide it? |
|
No idea, I'm just including as much as possible just in case |
|
Turns out Watson Buckets is a legacy diagnostic data leftover from the XP era. We'll be removing it from the serialization since its windows specific and a bit archaic. |
Closes #265