Fix missing default query configuration #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Not sure I understand the source of the fix - could you help me @Arkatufus ?
| @@ -68,7 +67,7 @@ public class SqlReadJournal : | |||
| _mat = Materializer.CreateSystemMaterializer( | |||
| context: system, | |||
| settings: ActorMaterializerSettings.Create(system), | |||
| namePrefix: $"l2db-query-mat{configPath}"); | |||
| namePrefix: $"l2db-query-mat-{Guid.NewGuid():N}"); | |||
There was a problem hiding this comment.
That was not the fix, the SqlReadJournal is a bit different in that it creates a materializer, which none of our other read journal does.
It tries to create a single materializer by appending the "config path".
The problem is that "config path" were never being passed into the provider, the provider was created through reflection magic and none of the activator code passes in the "config path".
So I just remove that ambiguous code and replace it with a GUID
Arkatufus
commented
Sep 14, 2023
| _system = system; | ||
| _config = config; | ||
| _configPath = configPath; | ||
| _config = config.WithFallback(SqlPersistence.DefaultQueryConfiguration); |
There was a problem hiding this comment.
This is the actual fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using HOCON configuration, default query configuration were not injected properly
Changes