-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize tag query by avoiding multi-query #223
Conversation
Another optimization I tried is by passing the original journal query into the tag query like so:
This actually degrades the performance:
|
row = jr, | ||
tags = tagTable | ||
.Where(r => r.OrderingId == jr.Ordering) | ||
.StringAggregate(";", r => r.TagValue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use SQL built-in string aggregate function to retrieve all tags in one go
@Arkatufus looks like this broke something across several Db implementations |
Should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
Use SQL built-in aggregate string to retrieve journal row and tags in 1 go
Latest
dev
BenchmarksThis PR's Benchmarks