Serialization pipeline Fixes/improvements #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lizer`, remove perf numbers till we make new ones
to11mtm
force-pushed
the
serialization-pipeline-improvements
branch
from
0bbd829
to
3748fcf
Compare
to11mtm
commented
May 2, 2021
Comment on lines
-84
to
+119
| deserialized = | ||
| Akka.Serialization.Serialization.WithTransport( | ||
| _serializer.System, | ||
| () => deserializer.FromBinary(t.message, type)); | ||
|
|
||
| return new Try<(IPersistentRepresentation, IImmutableSet<string> | ||
| , long)>(( | ||
| new Persistent( Akka.Serialization.Serialization.WithTransport( | ||
| _serializer.System, (_serializer.FindSerializerForType(type,_journalConfig.DefaultSerializer),t.message,type), | ||
| (state) => | ||
| { | ||
| return state.Item1.FromBinary( | ||
| state.message, state.type); | ||
| }), t.sequenceNumber, |
There was a problem hiding this comment.
If we look closely here, we are using FindSerializerForType here where we weren't previously. I think this was an oopsie in moving over the Serialization dance from SqlJournal, and it wasn't caught before because it would ONLY trip as a case when recovering from a very old version of the journal where we did not include an Identifier.
|
@Aaronontheweb Looks like Docker tests failing somehow =/. Confused cause I'm not sure what I broke? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumericRangeEntrybehavior to use ayieldfor it's Enumerator instead of allocating a bunch of lists.TStateoverloads For Seriallizer.WithTransportmethods to improve copies just a little