Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction isolation level to a configurable setting #207

Merged
merged 9 commits into from
Apr 25, 2023
Merged

Fix transaction isolation level to a configurable setting #207

merged 9 commits into from
Apr 25, 2023

Conversation

Arkatufus
Copy link
Contributor

@Arkatufus Arkatufus commented Apr 10, 2023 •
edited
Loading

Changes

  • Change journal and snapshot read/write transaction isolation mode to a configurable value to allow fine grain configuration

NOTE:

It looks like there's a bug with Linq2Db and MySql. MySql transaction could not take an unspecified isolation level, it would throw an SQL error if we do so.

@Arkatufus Arkatufus self-assigned this Apr 10, 2023
@Arkatufus Arkatufus marked this pull request as draft April 20, 2023 16:33
@Arkatufus Arkatufus changed the title Fix transaction isolation level to serializable to prevent race conditions Fix transaction isolation level to a configurable setting Apr 20, 2023
@Arkatufus Arkatufus marked this pull request as ready for review April 24, 2023 15:46
Aaronontheweb
Aaronontheweb approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 31b755a into akkadotnet:dev Apr 25, 2023
@Arkatufus Arkatufus mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees

@Arkatufus Arkatufus

Labels
None yet
Projects
No open projects
Akka.Persistence.Sql RTM deliveries
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkatufus @Aaronontheweb