Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Akka.Hosting extension methods #199

Merged
merged 10 commits into from
Apr 10, 2023

Conversation

Arkatufus
Copy link
Contributor

No description provided.

@Arkatufus Arkatufus self-assigned this Apr 6, 2023
@Arkatufus Arkatufus added enhancement New feature or request Akka.Hosting labels Apr 6, 2023
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback on the Akka.Hosting API surface area

</PropertyGroup>

<ItemGroup>
<PackageReference Include="Akka.Persistence.Hosting" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, version range for the MSFT.EXT packages is controlled by the base Akka.Hosting library.

{
public class JournalSettingsSpec
{
[Fact(DisplayName = "Default options should not override default hocon config")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{
public sealed class JournalDatabaseOptions
{
public static JournalDatabaseOptions Default => new(DatabaseMapping.Default)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the convenience of having ready-made "defaults" for each of the major supported databases here.

@Aaronontheweb
Copy link
Member

We need to add an example of using the hosting bits as well

@Aaronontheweb
Copy link
Member

I think doing some integration tests is probably the best way to go - let's use the Akka.Hosting.TestKit to do that.

protected override StringBuilder Build(StringBuilder sb)
{
if (string.IsNullOrWhiteSpace(ConnectionString))
throw new ArgumentNullException(nameof(ConnectionString), $"{nameof(ConnectionString)} can not be null or empty.");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where connection string value is being checked, we make sure that the user doesn't shoot themselves on the foot here.

Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 5fb3de6 into akkadotnet:dev Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Akka.Hosting enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants