Add Akka.Hosting extension methods #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Akka.Persistence.Hosting" /> |
There was a problem hiding this comment.
LGTM, version range for the MSFT.EXT packages is controlled by the base Akka.Hosting library.
| { | ||
| public class JournalSettingsSpec | ||
| { | ||
| [Fact(DisplayName = "Default options should not override default hocon config")] |
| { | ||
| public sealed class JournalDatabaseOptions | ||
| { | ||
| public static JournalDatabaseOptions Default => new(DatabaseMapping.Default) |
There was a problem hiding this comment.
I like the convenience of having ready-made "defaults" for each of the major supported databases here.
|
We need to add an example of using the hosting bits as well |
|
I think doing some integration tests is probably the best way to go - let's use the Akka.Hosting.TestKit to do that. |
Arkatufus
commented
Apr 7, 2023
| protected override StringBuilder Build(StringBuilder sb) | ||
| { | ||
| if (string.IsNullOrWhiteSpace(ConnectionString)) | ||
| throw new ArgumentNullException(nameof(ConnectionString), $"{nameof(ConnectionString)} can not be null or empty."); |
There was a problem hiding this comment.
This is where connection string value is being checked, we make sure that the user doesn't shoot themselves on the foot here.
CumpsD
reviewed
Apr 7, 2023
CumpsD
reviewed
Apr 7, 2023
CumpsD
reviewed
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.