Change default config values to be more greenfield friendly #195
Conversation
| @@ -16,12 +16,12 @@ | |||
| # If true, journal_metadata is created and used for deletes | |||
| # and max sequence number queries. | |||
| # note that there is a performance penalty for using this. | |||
| delete-compatibility-mode = true | |||
| delete-compatibility-mode = false | |||
There was a problem hiding this comment.
Change delete-compatibility-mode to false, we want to push the use of the new tag table for CQRS reasons
| @@ -48,7 +48,7 @@ | |||
| # Linq2Db by default will use a built string for multi-row inserts | |||
| # Somewhat counterintuitively, this is faster than using parameters in most cases, | |||
| # But if you would prefer parameters, you can set this to true. | |||
| prefer-parameters-on-multirow-insert = true | |||
| prefer-parameters-on-multirow-insert = false | |||
There was a problem hiding this comment.
Change prefer-parameters-on-multirow-insert to false.
Use of better optimized path should be encouraged.
| @@ -72,7 +72,7 @@ | |||
|
|
|||
| # Only set to TRUE if unit tests pass with the connection string you intend to use! | |||
| # This setting will go away once https://github.com/linq2db/linq2db/issues/2466 is resolved | |||
| use-clone-connection = false | |||
| use-clone-connection = true | |||
There was a problem hiding this comment.
Change use-clone-connection to true.
The original issue was closed with a temporary patch, it is better to leave this to true.
| @@ -99,7 +99,7 @@ | |||
| # should corresponding journal table be initialized automatically | |||
| # if delete-compatibility-mode is true, both tables are created | |||
| # if delete-compatibility-mode is false, only journal table will be created. | |||
| auto-initialize = off | |||
| auto-initialize = true | |||
There was a problem hiding this comment.
Persistence plugins should work as is out of the box, database tables should be initialized automatically.
This is open for discussion, should this be reverted?
There was a problem hiding this comment.
Nah, all other plugins work this way. LGTM.
| @@ -354,7 +363,7 @@ | |||
|
|
|||
| # Only set to TRUE if unit tests pass with the connection string you intend to use! | |||
| # This setting will go away once https://github.com/linq2db/linq2db/issues/2466 is resolved | |||
| use-clone-connection = false | |||
| use-clone-connection = true | |||
There was a problem hiding this comment.
Change use-clone-connection to true.
The original issue was closed with a temporary patch, it is better to leave this to true.
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| # Only set to TRUE if unit tests pass with the connection string you intend to use! | |||
| # This setting will go away once https://github.com/linq2db/linq2db/issues/2466 is resolved | |||
| use-clone-connection = false | |||
| use-clone-connection = true | |||
There was a problem hiding this comment.
Change use-clone-connection to true.
The original issue was closed with a temporary patch, it is better to leave this to true.
| @@ -30,10 +30,8 @@ | |||
|
|
|||
| dao = "Akka.Persistence.Sql.Snapshot.ByteArraySnapshotDao, Akka.Persistence.Sql" | |||
|
|
|||
| compatibility-mode = false | |||
There was a problem hiding this comment.
This setting was never used in code
| # if true, tables will attempt to be created. | ||
| auto-initialize = false | ||
| auto-initialize = true |
There was a problem hiding this comment.
Persistence plugins should work as is out of the box, database tables should be initialized automatically.
This is open for discussion, should this be reverted?
There was a problem hiding this comment.
Makes sense to me, I start greenfield from an empty db
There was a problem hiding this comment.
LGTM - we can gather data from users like @CumpsD and others who want to use this in new projects how well this all works
| @@ -16,12 +16,12 @@ | |||
| # If true, journal_metadata is created and used for deletes | |||
| # and max sequence number queries. | |||
| # note that there is a performance penalty for using this. | |||
| delete-compatibility-mode = true | |||
| delete-compatibility-mode = false | |||
| @@ -48,7 +48,7 @@ | |||
| # Linq2Db by default will use a built string for multi-row inserts | |||
| # Somewhat counterintuitively, this is faster than using parameters in most cases, | |||
| # But if you would prefer parameters, you can set this to true. | |||
| prefer-parameters-on-multirow-insert = true | |||
| prefer-parameters-on-multirow-insert = false | |||
| @@ -72,7 +72,7 @@ | |||
|
|
|||
| # Only set to TRUE if unit tests pass with the connection string you intend to use! | |||
| # This setting will go away once https://github.com/linq2db/linq2db/issues/2466 is resolved | |||
| use-clone-connection = false | |||
| use-clone-connection = true | |||
| @@ -99,7 +99,7 @@ | |||
| # should corresponding journal table be initialized automatically | |||
| # if delete-compatibility-mode is true, both tables are created | |||
| # if delete-compatibility-mode is false, only journal table will be created. | |||
| auto-initialize = off | |||
| auto-initialize = true | |||
There was a problem hiding this comment.
Nah, all other plugins work this way. LGTM.
Once the documentation is in, I will test it in a greenfield project :) |
|
I migrated and it works fine out of the box 👍🏻 |
Fixes #194
Changes
delete-compatibility-modetofalseprefer-parameters-on-multirow-inserttofalseuse-clone-connectiontotrueauto-initializetotrueuse-clone-connectiontotrueuse-clone-connectiontotrueauto-initializetotruecompatibility-mode, it is not being used.