Fix read journal, missing _includeDeleted checks
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to11mtm
approved these changes
Nov 13, 2022
to11mtm
reviewed
Nov 24, 2022
| @@ -171,7 +167,7 @@ public async Task<long> MaxJournalSequenceAsync() | |||
| { | |||
| await using var db = ConnectionFactory.GetConnection(); | |||
|
|
|||
| return await db.GetTable<JournalRow>() | |||
| return await BaseQueryStatic(db, _includeDeleted) | |||
There was a problem hiding this comment.
So, I'm realizing now (After approval) that this line should not have been changed;
Here are the queries from AFTER 'include-deleted' support was pulled from persistence-jdbc (But before license change! ;))
The max journal 'sequence' (Ordering) does -not- have a filter on isDeleted. If I had to guess, including deleted in Max Ordering -probably- improves some edge cases around JournalSequenceActor, namely in cases where all of the entries in the journal are soft-delete records, (If that happened, there would be a delay on seeing new events, as the Journal Sequence actor would take time to look for the sequence gap.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for #117
Persistence query returned wrong number of events because it also includes soft deleted entries.