Update common.props usage and upgrade all package versions #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Nov 3, 2022
| @@ -1,4 +1,5 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <Import Project="..\src\common.props" /> | |||
There was a problem hiding this comment.
We can skip explicitly referencing common.props if we just name the file Directory.Build.props, which is probably how we should do this going forward.... BUUUT dependabot may not like it.... So we'll stick with this for now.
| @@ -18,7 +18,7 @@ jobs: | |||
| parameters: | |||
| name: 'windows_pr' | |||
| displayName: 'Windows PR Validation' | |||
| vmImage: 'vs2017-win2016' | |||
| vmImage: 'windows-2019' | |||
There was a problem hiding this comment.
Will need to explicitly install the versions of .NET we need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes