Akka.Cluster.Hosting: don't use sharding delegates #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laying the groundwork for akkadotnet/akka.net#6863 here - besides, it looks like the old delegates simply can't handle certain messages automatically due to akkadotnet/akka.net#7051
Aaronontheweb
commented
Jan 9, 2024
| @@ -869,8 +847,23 @@ private static ExtractShardId ToExtractShardId(this IMessageExtractor self) | |||
| IMessageExtractor messageExtractor, | |||
| ShardOptions shardOptions) | |||
| { | |||
| return builder.WithShardRegion<TKey>(typeName, entityPropsFactory, | |||
| messageExtractor.ToExtractEntityId(), messageExtractor.ToExtractShardId(), shardOptions); | |||
| shardOptions.Apply(builder); | |||
There was a problem hiding this comment.
had to move 1st citizen sharding code here, although it kind of duplicates the methods that work directly with the Extractor delegates right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
laying the groundwork for akkadotnet/akka.net#6863 here - besides, it looks like the old delegates simply can't handle certain messages automatically due to akkadotnet/akka.net#7051
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):