Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PassivateIdleEntityAfter to not override HOCON settings #318

Merged
merged 3 commits into from
May 30, 2023
Merged

Fix PassivateIdleEntityAfter to not override HOCON settings #318

merged 3 commits into from
May 30, 2023

Conversation

Arkatufus
Copy link
Contributor

Fixes #303

Changes

  • Make PassivateIdleEntityAfter default value to null
  • Add ShouldPassivateIdleEntities property to disable idle entity passivation

Aaronontheweb
Aaronontheweb approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb enabled auto-merge (squash) May 30, 2023 23:33
@Aaronontheweb Aaronontheweb merged commit 0a5e7af into akkadotnet:dev May 30, 2023
@Arkatufus Arkatufus mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Arkatufus @Aaronontheweb