Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JMS & Google pubsub grpc: Update Mima excludes #1874

Merged
merged 2 commits into from
Aug 9, 2019
Merged

JMS & Google pubsub grpc: Update Mima excludes #1874

merged 2 commits into from
Aug 9, 2019

Conversation

ennru
Copy link
Member

@ennru ennru commented Aug 9, 2019

  • Rename the JMS excludes file
  • Add exclude file for generated Google Cloud Pub-Sub gRPC classes

2m
2m reviewed Aug 9, 2019
View reviewed changes
google-cloud-pub-sub-grpc/src/main/mima-filters/2.0.0.backwards.excludes Outdated
@@ -0,0 +1,6 @@
# PR #1781 Updated dependencies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file should be 1.1.x.backwards.excludes.

@ennru
Copy link
Member Author

ennru commented Aug 9, 2019 •
edited
Loading

Thanks, I always get that wrong.

2m
2m approved these changes Aug 9, 2019
View reviewed changes
Copy link
Contributor

@2m 2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ennru
Copy link
Member Author

ennru commented Aug 9, 2019

Failure was #1306

@ennru ennru merged commit b2d799b into akka:master Aug 9, 2019
@ennru ennru deleted the mima-excludes-2.0 branch August 9, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2m 2m 2m approved these changes

Assignees
No one assigned
Labels
p:google-cloud-pub-sub-grpc p:jms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ennru @2m