Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update akka-grpc to 0.6 #1564

Merged
merged 4 commits into from
Mar 13, 2019
Merged

Update akka-grpc to 0.6 #1564

merged 4 commits into from
Mar 13, 2019

Conversation

2m
Copy link
Member

@2m 2m commented Mar 7, 2019

Purpose

Updates to the just released akka-grpc 0.6.

Had to drop 2.11 for Google Pub/Sub gRPC because akka-grpc does not support it anymore akka/akka-grpc#520

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru
Copy link
Member

ennru commented Mar 11, 2019

Build failure for 2.11

[error] sbt.librarymanagement.ResolveException: unresolved dependency: com.lightbend.akka#akka-stream-alpakka-google-cloud-pub-sub-grpc_2.11;1.0-M3+24-2aa67921: not found

But 2.13 compilation works. How can that be?

@2m 2m force-pushed the wip-update-akka-grpc-2m branch from 47ce9bd to 7c393e1 Compare March 12, 2019 13:32
@2m
Copy link
Member Author

2m commented Mar 12, 2019

The ++ does the right thing, where it does not run the specified command on the projects that do not have specified Scala version in crossScalaVersions. Thats why compilation with 2.13 works.

The validation problem here with 2.11 was that Alpakka Google Pub/Sub gRPC is not available for 2.11 anymore, but doc-examples is still built with 2.11 and it depends on Pub/Sub connector.

Added a fix to stop compiling doc-examples with 2.11.

@ennru
Copy link
Member

ennru commented Mar 13, 2019

Failures were #1549 and #1578

@ennru ennru merged commit 7acaf7e into akka:master Mar 13, 2019
@ennru ennru added this to the 1.0-M4/RC1 milestone Mar 13, 2019
@2m 2m deleted the wip-update-akka-grpc-2m branch March 13, 2019 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants