gardening: remove use of IntegrationTest scope #1666
Conversation
ennru
force-pushed
the
ennru-move-it
branch
from
92f582d
to
f32ec27
Compare
|
The integration tests ran and worked, but I don't see why "Build and Test" didn't execute properly. |
|
Rebased on main |
| .settings( | ||
| name := "akka-stream-kafka-tests", | ||
| libraryDependencies ++= Seq( | ||
| "com.typesafe.akka" %% "akka-discovery" % akkaVersion, | ||
| "com.google.protobuf" % "protobuf-java" % "3.23.3", // use the same, or later, version as in scalapb | ||
| "org.testcontainers" % "kafka" % testcontainersVersion, |
There was a problem hiding this comment.
I would have expected that this project would not need test containers, but that would be in integrationTests? Benchmarks could depend on integrationTests if that is the reason.
One advantage of that is that it's more clear when someone adds such tests that it should be in the integrationTests project and not in tests.
There was a problem hiding this comment.
Most Alpakka Kafka tests need a Kafka instance to talk to, they share a Kafka provided via TestContainers.
The difference for the Integration Tests is that they run test specific Kafkas TestcontainersKafkaPerClassLike with specific configuration.
Very few classes from 'tests' are referenced from the |
|
One thought after starting on something parallel in akka-management, can we follow a common naming scheme for these, I think the recommendation in the sbt deprecation was |
|
Build success! |
ennru
force-pushed
the
ennru-move-it
branch
2 times, most recently
from
7f10dd3
to
45dd000
Compare
|
Rebased in the hope that the updated GH actions from |
|
System.IO.IOException: No space left on device : '/home/runner/runners/2.314.1/_diag/Worker_20240308-111255-utc.log' |
|
Something to try: actions/runner-images#2840 (comment) |
The
IntegrationTestscope is deprecated since sbt 1.9.Moving integration tests to a separate project instead which now depends on the
testsproject for shared code and dependencies.Refs