bump: Akka gRPC 2.4.4, Akka 2.9.6 #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanandren
approved these changes
Oct 2, 2024
|
compiler warning comes from akka-grpc: akka/akka-grpc#1992 |
|
Can we disable the interpolation check here for now or do you think we should we should do another grpc release? I don't expect that path to be hit often (someone calling the a specific grpc service, not with a missing method but with an invalid path following the service name) |
|
Best would be if we can disable fatal warnings for all Akka gRPC generated sources, since this project is not in control of them. |
|
ok, I'll try to disable that here |
johanandren
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.