feat: Skip backtracking when far behind,Accept PubSub events after idle #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PubSub events are ignored if they are too far ahead of backtracking. * That means that they will always be ignored after an idle period. * This emits heartbeat events when the query is idle and thereby progress the backtracking timestamp in the PubSub filter. * wall clock duration since latest backtracking event * including fake persistenceId corresponding to the slice * don't deduplicate heartbeat * mima filter * unique heartbeat persistenceId
(cherry picked from commit c259b5a)
This was referenced Oct 18, 2024
patriknw
added a commit
that referenced
this pull request
Oct 18, 2024
…le (#614) * feat: Accept PubSub events after idle * PubSub events are ignored if they are too far ahead of backtracking. * That means that they will always be ignored after an idle period. * This emits heartbeat events when the query is idle and thereby progress the backtracking timestamp in the PubSub filter. * base relative heartbeat timestamps on initial database time * previous query wall clock minus backtracking behind current time * including fake persistenceId corresponding to the slice * don't deduplicate heartbeat * mima filter * unique heartbeat persistenceId * filter heartbeats early in pubsub merge * feat: Skip backtracking when far behind --------- Co-authored-by: Peter Vlugter <[email protected]> (cherry picked from commit c7899d1)
This was referenced Oct 18, 2024
patriknw
added a commit
that referenced
this pull request
Oct 18, 2024
…le (#614) (#615) * feat: Accept PubSub events after idle * PubSub events are ignored if they are too far ahead of backtracking. * That means that they will always be ignored after an idle period. * This emits heartbeat events when the query is idle and thereby progress the backtracking timestamp in the PubSub filter. * base relative heartbeat timestamps on initial database time * previous query wall clock minus backtracking behind current time * including fake persistenceId corresponding to the slice * don't deduplicate heartbeat * mima filter * unique heartbeat persistenceId * filter heartbeats early in pubsub merge * feat: Skip backtracking when far behind --------- Co-authored-by: Peter Vlugter <[email protected]> (cherry picked from commit c7899d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we had a stack of related PRs I incorporated them into one single PR. This includes