Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Save offsets in Batch without bind parameters, #253 (#255)" #259

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Revert "Save offsets in Batch without bind parameters, #253 (#255)" #259

merged 1 commit into from
Jul 5, 2022

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Jul 4, 2022 •
edited
Loading

This reverts commit 2ea4121.

Since there was objections in #255 (comment)

Refs akka/akka-projection#897

@patriknw patriknw requested a review from jrudolph July 4, 2022 11:20
jrudolph
jrudolph approved these changes Jul 5, 2022
View reviewed changes
Copy link

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's postpone until we need it definitely and hope for an upstream fix. I'll create a ticket.

@johanandren johanandren merged commit 039e400 into main Jul 5, 2022
@johanandren johanandren deleted the wip-revert-batch-patriknw branch July 5, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

@jrudolph jrudolph jrudolph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patriknw @jrudolph @johanandren