Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Delete effect for DurableState #686

Open
patriknw opened this issue Sep 22, 2022 · 3 comments
Open

Implement Delete effect for DurableState #686

patriknw opened this issue Sep 22, 2022 · 3 comments
Labels
bug 🐛

Comments

@patriknw
Copy link
Member

DeletedDurableState in the query.

Also implement deleteObject(persistenceId: String, revision: Long) correctly, so that it keeps latest record but updates payload to null. Similar to how events are deleted. When loading it should continue from latest revision even if it is deleted.

See akka/akka#31529
johanandren pushed a commit that referenced this issue Sep 22, 2022
@patriknw
Update to Akka 2.7.0-M1 (#685)
362d8a7 
* Update to Akka 2.7.0-M1
* and sbt 1.7.1
* and cleanup of scala versions in ci builds
* temporary deleteObject impl (real one to follow, see #686 )
@leviramsey
Copy link
Contributor

Seems completed?

@patriknw
Copy link
Member Author

patriknw commented Aug 7, 2023

I think something is still missing in the implementation

akka-persistence-jdbc/core/src/main/scala/akka/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala

Line 109 in 500642d

// FIXME #686 use revision

@danieltahara
Copy link

danieltahara commented Feb 14, 2024 •
edited
Loading

Just hit this I think

If you perform Effect.delete but don't stop the actor, then actor expects its sequence number is incremented so any subsequent update fails.

However, the DB expects that the sequence number should be 1 b/c it doesn't have a row in the database. The actor is now wedged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patriknw @danieltahara @leviramsey