feat: Initial journal implementation #2
Conversation
patriknw
commented
May 24, 2024
patriknw
commented
- write and replay events
- client provider
- config structure
* write and replay events * client provider * config structure
| } | ||
| } | ||
|
|
||
| class DynamoDBJournalSpec extends JournalSpec(DynamoDBJournalSpec.config) with TestDbLifecycle { |
There was a problem hiding this comment.
Some tests (related to deletes) will fail because that isn't implemented yet. I think we can merge this anyway after review, and add that in separate pr.
There was a problem hiding this comment.
Good to see the initial journal implementation.
Tried it out locally, and while looking also made some fixes directly — can push separately.
CI tests are not bringing up the local DynamoDB. Looks like the docker compose version thing that we've seen before (docker-compose vs docker compose). Can check in another PR.
|
|
||
| existingTable.transformWith { | ||
| case Success(_) => delete().flatMap(_ => create()) | ||
| case Failure(_: ResourceNotFoundException) => create() |
There was a problem hiding this comment.
When trying locally it's not creating the table. Because this is wrapped in a future CompletionException.
There was a problem hiding this comment.
Added case for CompletionException in #3.
| import JournalAttributes._ | ||
| val req = QueryRequest.builder | ||
| .tableName(settings.journalTable) | ||
| .keyConditionExpression(s"$Pid = :pid AND $SeqNr BETWEEN :from AND :to") |
There was a problem hiding this comment.
This is failing on one of the tests when running locally.
must not replay messages if count limit equals 0
Invalid KeyConditionExpression: The BETWEEN operator requires upper bound to be greater than or equal to lower bound
The logic copied from r2dbc plugin has to < from when max/limit is 0.
Could be a check in this method, return empty source.
| // FIXME very inefficient implementation, can we get rid of the separate ReadHighestSequenceNr query | ||
| // altogether and rely on latest event in the replay? Requires some changes in Akka, but would | ||
| // be good performance improvement. |
There was a problem hiding this comment.
I think we can have a more efficient query for DynamoDB now as well — should be possible to get the last item for a partition key, which would be the highest sequence number.
There was a problem hiding this comment.
Added a last item query (backwards scan with limit of 1) to get highest sequence number directly, in #3.
|
|
||
| The following client settings be overridden in the `client` block: | ||
|
|
||
| @@snip [reference.conf](/core/src/main/resources/reference.conf) {#client-settings} |
There was a problem hiding this comment.
Failing docs in CI, with Label [client-settings] block not closed.
There was a problem hiding this comment.
Added the missing label in #3.
Fixed in #3. |
