Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Remote-Address header #3174

Merged
merged 3 commits into from
May 21, 2020
Merged

Deprecate Remote-Address header #3174

merged 3 commits into from
May 21, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented May 20, 2020

Migration note is already part of #3173
Refs #2924

@raboof
Deprecate Remote-Address header
fc44a4c 
Migration note is already part of akka#3173
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins needs-attention Indicates a PR validation failure (set by CI infrastructure) and removed validating PR that is currently being validated by Jenkins labels May 20, 2020
@akka-ci
Copy link

akka-ci commented May 20, 2020

Test FAILed.

!!! Couldn't read commit file !!!

@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed needs-attention Indicates a PR validation failure (set by CI infrastructure) validating PR that is currently being validated by Jenkins labels May 20, 2020
@akka-ci
Copy link

akka-ci commented May 20, 2020

Test PASSed.

jrudolph
jrudolph approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ennru
ennru approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@raboof raboof merged commit 38ec9fc into akka:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

@jrudolph jrudolph jrudolph approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raboof @akka-ci @jrudolph @ennru