Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add generators objects #533

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Re-add generators objects #533

merged 1 commit into from
Feb 27, 2019

Conversation

marcospereira
Copy link
Contributor

Power users can create instances of the case classes with powerApis = true, so no need to add another object here.

This keeps things consistent with how the generators are used in build.sbt.

@akka-ci
Copy link

akka-ci commented Feb 26, 2019

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

@raboof
Copy link
Member

raboof commented Feb 27, 2019

OK TO TEST

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a smell when this generator is used without specifying whether we want to generate power API's or not?

I'm OK with this change if it's useful for play-grpc though.

Eventually we'd want to remove this 'all-or-nothing' parameter from the generator, and instead specify it on a per-service (or even per-method) level, but that is future work (#451)

@ignasi35 ignasi35 merged commit c97a24a into akka:master Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants