Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Scala XML 2.1.0 across the modules #1736

Merged
merged 9 commits into from
Jan 11, 2023
Merged

Conversation

johanandren
Copy link
Member

No description provided.

@ennru
Copy link
Member

ennru commented Jan 5, 2023

Twirl 1.5.2 was released with Scala XMl 2.1.0 https://github.com/playframework/twirl/releases/tag/1.5.2

@johanandren
Copy link
Member Author

Next problem(s):

[error] 	* org.scala-lang.modules:scala-xml_2.12:2.1.0 (early-semver) is selected over {1.0.6, 1.3.0}
[error] 	    +- org.scala-lang:scala-compiler:2.12.17              (depends on 2.1.0)
[error] 	    +- com.typesafe.play:twirl-api_2.12:1.5.2             (depends on 2.1.0)
[error] 	    +- ws.unfiltered:unfiltered_2.12:0.10.4               (depends on 1.3.0)
[error] 	    +- org.foundweekends:knockoff_2.12:0.8.6              (depends on 1.0.6)

@ennru
Copy link
Member

ennru commented Jan 5, 2023

These dependencies come from sbt-site which pulls in all site generators. That's why I tried to pull it apart in sbt/sbt-site#203

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@johanandren johanandren merged commit 89164a0 into main Jan 11, 2023
@johanandren johanandren deleted the wip-bump-scala-xml-2 branch January 11, 2023 16:47
@johanandren johanandren added this to the 2.3.0-M2 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants