Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Akka HTTP 10.2.0 #1087

Merged
merged 9 commits into from
Oct 2, 2020
Merged

Update to Akka HTTP 10.2.0 #1087

merged 9 commits into from
Oct 2, 2020

Conversation

jrudolph
Copy link
Member

@jrudolph jrudolph commented Aug 4, 2020 •
edited by raboof
Loading

Follow up to #937. Currently only as fodder to the validation.

Refs #914

@ennru ennru mentioned this pull request Aug 4, 2020
Closed
4 tasks
@raboof raboof force-pushed the test-with-almost-10.2.0-final branch from 04746fc to 82fbb09 Compare August 10, 2020 13:21
@raboof raboof changed the title Test with almost 10.2.0 final Update to Akka HTTP 10.2.0 Aug 10, 2020
@raboof raboof mentioned this pull request Aug 10, 2020
Closed
@raboof raboof removed the sbt label Aug 10, 2020
@raboof
Copy link
Member

raboof commented Aug 10, 2020

@jrudolph we can probably undraft this?

@raboof raboof mentioned this pull request Aug 10, 2020
Merged
@jrudolph
Copy link
Member Author

@jrudolph we can probably undraft this?

From my side, yes. I guess it depends on what the plans are for Akka gRPC regarding keeping support for Akka HTTP 10.1.x?

@raboof
Copy link
Member

raboof commented Aug 11, 2020

I guess it depends on what the plans are for Akka gRPC regarding keeping support for Akka HTTP 10.1.x?

I think we should update to Akka HTTP 10.2.x and Akka 2.6.x in Akka gRPC 1.1.0, but we haven't set a timeline for that yet.

@raboof raboof added this to the 1.1.0 milestone Aug 11, 2020
@jrudolph
Copy link
Member Author

I think we should update to Akka HTTP 10.2.x and Akka 2.6.x in Akka gRPC 1.1.0, but we haven't set a timeline for that yet.

Sounds good!

So, should this go in an extra branch, then? Or will we branch off for 1.0.x releases if needed?

@jrudolph jrudolph marked this pull request as ready for review August 11, 2020 12:33
raboof
raboof approved these changes Oct 2, 2020
View reviewed changes
plugin-tester-java/src/test/scala/example/myapp/helloworld/ErrorReportingSpec.scala
Http(sys).bindAndHandleAsync(handler, ConnectHttp.toHost("127.0.0.1", 0), mat).toCompletableFuture.get
Http(sys)
.newServerAt("127.0.0.1", 0)
.bind((req => handler(req)): akka.japi.function.Function[HttpRequest, CompletionStage[HttpResponse]])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can (and should) make this simpler (#1101), but we can do that in a separate PR

@raboof raboof merged commit 78d17a7 into master Oct 2, 2020
@raboof raboof mentioned this pull request Jan 19, 2021
Closed
@jrudolph jrudolph deleted the test-with-almost-10.2.0-final branch July 15, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
sbt update
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jrudolph @raboof @ennru