Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Play-specific code to their own repo's #517

Closed
raboof opened this issue Jan 29, 2019 · 5 comments
Closed

Move Play-specific code to their own repo's #517

raboof opened this issue Jan 29, 2019 · 5 comments
Labels
enhancement New feature or request play issues regarding play interoperability
Milestone

Comments

@raboof
Copy link
Member

raboof commented Jan 29, 2019

A lot of the Play-specifics are already in a separate repository at https://github.com/playframework/play-grpc , but the code generation itself is still in akka-grpc.

It made sense to keep it close to the Akka code generation when the code generation API's were still evolving quickly, but we do plan to move them out. Since the Akka gRPC infrastructure allows contributing code generators from 'outside' this should be relatively feasible.

Perhaps good to finish #420 first, though.

@raboof raboof added enhancement New feature or request play issues regarding play interoperability labels Jan 29, 2019
@dwijnand
Copy link
Member

Who knows the Play generators and could help maintain them in play-grpc?

@raboof
Copy link
Member Author

raboof commented Jan 29, 2019

I think at least myself, @renatocaval, @johanandren and (esp. when #420 is resolved) @ctoomey?

@ctoomey
Copy link
Contributor

ctoomey commented Jan 30, 2019

Yep I could help a bit after #420, which I'll tackle again once #179 is merged. As far as that goes I've done everything except update the documentation, which I'll do soon.

@raboof
Copy link
Member Author

raboof commented May 27, 2019

The next step here would be to make the akka-grpc configuration API's powerful enough so Play generators can be inserted without Play-specific knowledge in akka-grpc.

This is already the case for sbt (via akkaGrpcExtraGenerators, i.e. https://developer.lightbend.com/docs/play-grpc/current/play/serving-grpc.html), and we should find a way to expose that for Gradle users (who currently use the generatePlay/usePlayActions gradle plugin settings) and Maven users (who currently use specific generatePlayClient/generatePlayServer/usePlayActions settings).

After that, we can move the generators themselves to their own play-grpc-generators artifact, and introduce a play-grpc-runtime to hold the parts of the runtime that hook into Play.

@raboof raboof mentioned this issue May 27, 2019
2 tasks
@raboof
Copy link
Member Author

raboof commented Feb 12, 2020

this has been done

@raboof raboof closed this as completed Feb 12, 2020
@ennru ennru added this to the invalid milestone Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request play issues regarding play interoperability
Projects
None yet
Development

No branches or pull requests

4 participants