-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Play-specific code to their own repo's #517
Comments
Who knows the Play generators and could help maintain them in play-grpc? |
I think at least myself, @renatocaval, @johanandren and (esp. when #420 is resolved) @ctoomey? |
The next step here would be to make the akka-grpc configuration API's powerful enough so Play generators can be inserted without Play-specific knowledge in akka-grpc. This is already the case for sbt (via After that, we can move the generators themselves to their own |
this has been done |
A lot of the Play-specifics are already in a separate repository at https://github.com/playframework/play-grpc , but the code generation itself is still in akka-grpc.
It made sense to keep it close to the Akka code generation when the code generation API's were still evolving quickly, but we do plan to move them out. Since the Akka gRPC infrastructure allows contributing code generators from 'outside' this should be relatively feasible.
Perhaps good to finish #420 first, though.
The text was updated successfully, but these errors were encountered: