Fix gradle plugin publish (#330)

* Travis command had missing quote * Versions that are a tag still ended up with a commit hash
akka · Aug 8, 2018 · fff5651 · fff5651
1 parent ec375f4
commit fff5651
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -31,7 +31,7 @@ jobs:
       script: git branch -f "$TRAVIS_BRANCH" && git checkout "$TRAVIS_BRANCH" && sbt whitesourceCheckPolicies whitesourceUpdate
     - stage: publish
       script: sbt publish
-    - script: cd gradle-plugin && echo "gradle.publish.key=AwHNbsVBKA20KPzWQyCRbgGQHWa9Us5Y\ngradle.publish.secret=$GRADLE_SECRET' > ~/.gradle/gradle.properties && ./gradlew publishPlugins
+    - script: cd gradle-plugin && echo "gradle.publish.key=AwHNbsVBKA20KPzWQyCRbgGQHWa9Us5Y\ngradle.publish.secret=$GRADLE_SECRET" > ~/.gradle/gradle.properties && ./gradlew publishPlugins
     - stage: techhub-ping
       script: curl -I https://ci.lightbend.com/job/techhub-publisher/build?token=$TECH_HUB_TOKEN
 

diff --git a/gradle-plugin/build.gradle b/gradle-plugin/build.gradle
@@ -19,7 +19,11 @@ plugins {
 
 group = "com.lightbend.akka.grpc"
 // https://github.com/palantir/gradle-git-version/issues/97
-version "git describe --tags".execute().text.substring(1).split("-g")[0].replace('-', '+') + "-" + versionDetails().gitHash.substring(0, 8)
+
+def tag = "git describe --tags".execute().text.substring(1).split("-g")[0].replace("\n", "")
+def finalVersion = (tag == versionDetails().lastTag.substring(1)) ? tag : tag.replace("-", "+") + "-" + versionDetails().gitHash.substring(0, 8)
+
+version = finalVersion
 
 gradlePlugin {
     plugins {