Call the rate limiter many times in the same php code with different limits

[leonardoxc]

With this branch we can do this:

$memcache = new Memcache;
$memcache->connect('127.0.0.1',11211);

$rateLimiter = new RateLimiter($memcache, $_SERVER["REMOTE_ADDR"]);
try {
    // 10 requests / minute
    $rateLimiter->limitRequestsInMinutes(10, 1);
} catch (RateExceededException $e) {
    header("HTTP/1.0 529 Too Many Requests");
    exit;
}

try {
    // 30 requests / 5 minute
    $rateLimiter->limitRequestsInMinutes(30, 5);
} catch (RateExceededException $e) {
    header("HTTP/1.0 529 Too Many Requests");
    exit;
}

etc....

[akirk]

Apart from the mix of coding standards, I am not sure about the logic you introduce. Why the subtraction part, instead of simply not counting it in the first place, if it had been visited in the current request already? So instead of $keysvisited we could do a $already_counted and skip the increment part when that has already been done.

[akirk]

Please add whitespace around the =.

[akirk]

In accordance with the rest of the code, this should not output something but throw an exception.

[akirk]

Please add whitespace around the =.

[akirk]

Typo

[akirk]

Please add whitespace around the =.

[akirk]

This library should not output anything. This text could be placed in the Exception description, though.

[akirk]

Please add whitespace around the -=.

[akirk]

This should be checked with an isset() or it will generate a warning.

[akirk]

Extra whitespace ahead of the comma.