Add color row widget #604
Merged
Add color row widget #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbfraga
approved these changes
Jun 12, 2021
madjesc
pushed a commit
to madjesc/Akira
that referenced
this pull request
Jun 28, 2021
* Move color picker code to its own class * Move color field inside reusable color picker widget * Move the opacity field in the color button widget * Update the item fill color when the opacity field is changed * Properly update colors and alpha of items and UI buttons * Use a shared ColorModel for fills and borders * Reload list of fill deletion * Remove 2 way bindings for color fields * Hook border to reusable UI widget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / How this PR fixes the problem?
This PR aims at removing some overhead from the connection between the item's components
FillandBorderand the UI widgets.Along the way it fixes some syncing issues between the input fields and color pickers, as well as creating reusable widgets and removing code duplication.
Steps to Test
Use the fills and borders as usual and nothing should look different.
Screenshots
TBD
Known Issues / Things To Do
ColorModelin order to dynamically use theFillorBordercomponent in the same Widget. Maybe a better method is out there but I don't know.enum Typeto distinguish the components in the UI, also maybe here there's a better approach we could use.'ColorChooserand theColorInputandOpacityInputit's a bit weird with a manual boolean variable set to prevent infinite loop. Maybe something smarter could be done?This PR fixes/implements the following bugs/features:
Modelsfor Fills and Colors and stops using the uber complicatedModels/ListModelwhich is a bit overkill for what we need.ColorRowwidget shared between Borders and Fills.