ArchiveUnpacker now preserves "executable" permissions in Tar and Zip #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecause it allows for getting the unix file mode.
…mine if it needs to call File.setExecutable(true).
…ncible to future bugs - don't want to crash if CommonsCompress has a bug in its permissions code.
akhikhl
added a commit
that referenced
this pull request
Sep 16, 2015
ArchiveUnpacker now preserves "executable" permissions in Tar and Zip
|
Merged it into snapshot version. Will test and release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unpuzzle extracts the eclipse archives, it doesn't preserve the executable bits. This means that if you want to use unpuzzle to install a runnable Eclipse, it doesn't work on Linux or Mac. This PR fixes this issue.