Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old emacs-module.h vs using one from an Emacs installation #709

Open
manphiz opened this issue Mar 18, 2024 · 5 comments
Open

Old emacs-module.h vs using one from an Emacs installation #709

manphiz opened this issue Mar 18, 2024 · 5 comments

Comments

@manphiz
Copy link
Contributor

manphiz commented Mar 18, 2024

It looks like emacs-module.h was copied from the Emacs source tree 6 years ago. I wonder whether this file was kept from being updated so as to be compatible with older Emacs versions?

Meanwhile, is it desirable to let emacs-libvterm detect an existing Emacs installation and use the emacs-module.h from that if available?

@Sbozzolo
Copy link
Collaborator

Is there anything you would like to have from more recent versions?

@manphiz
Copy link
Contributor Author

manphiz commented May 21, 2024 via email

@Sbozzolo
Copy link
Collaborator

Sbozzolo commented Jun 1, 2024

Yes, I agree.

It is immediately clear to me that we want to use the most recent emacs-module.h all the time. If the it changes signficantly (ie, in a non-backward compatible way), we would need to change our vterm-module too. Similarly, if we wanted to take advantage of newer features, we would probably have to add compatibility on our end.

manphiz added a commit to manphiz/emacs-libvterm that referenced this issue Sep 10, 2024
* Prefer to use system installed emacs-module.h header.
* Fallback to vendored header when it is not found.
* Enable the option by default.
* Fixes issue akermu#709.
@manphiz
Copy link
Contributor Author

manphiz commented Sep 10, 2024

Just opened PR #735 as an attempt. PTAL.

@manphiz
Copy link
Contributor Author

manphiz commented Oct 2, 2024

Friendly ping for #735, which adds an option in CMake to prefer emacs-module.h from an Emacs installation over the vendored version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants