Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing step in the documentation #980

Open
wants to merge 3 commits into
base: 2.3
Choose a base branch
from
Open

Conversation

bOnepain
Copy link

@bOnepain bOnepain commented Aug 3, 2018

Added a missing step to "deploy" requirejs.yml files when customizing any frontend part of the application.

Definition Of Done

Q A
Technical Review and 2 GTM Todo
English Review and 1 GTM Todo

Todo: Pending / Work in progress
OK: Done / Validated
-: Not needed

@damien-carcel
Copy link
Contributor

Hello @bOnepain.

Sorry we didn't handle your contribution sooner. This adding is in fact not necessary, as the pim:installer:dump-require-paths command is already ran by the pim:installer:assets one.
You can look at this script: https://github.com/akeneo/pim-community-dev/blob/master/bin/pim-front.sh.
With that, you build everything for the front-end.

@bOnepain
Copy link
Author

Hello @damien-carcel
Indeed, I noticed later that the command you're mentionning also dumps the paths. But in that case, wouldn't it be a good idea to mention it in the documentation. At the moment there's only the
bin/console assets:install in the documentation. Not the pim:installer:assets. Tell me whether I change my PR or not... thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants