Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PIM install command for docker #1746

Merged
merged 1 commit into from
Mar 4, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion install_pim/docker/installation_docker.rst
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ The following command will create a PIM project in the current directory. Please
$ cd pim
$ docker run -ti -u www-data --rm \
-e COMPOSER_MEMORY_LIMIT=4G \
-v $(pwd):/srv/pim -v ~/.composer:/var/www/.composer -w /srv/pim \
-v $(pwd):/srv/pim -v ~/.composer:/var/www/.composer -w /srv/pim -v ~/.cache:/var/www/.cache \
Copy link
Contributor

@ValentinMerlet ValentinMerlet Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the composer documentation, the composer cache directory path can vary from one unix system to another so it won't work for anyone: https://getcomposer.org/doc/06-config.md#cache-dir.
Also, can there be an impact to mount all the ~/.cache directory? There is a lot of cache in it, not only composer one, it can be several GB.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @BitOne you have a feedback on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mount is just a kind of link, so the size doesn't matter (nothing is copied or transferred).

According to the documentation, on Unix systems it's either .cache/composer or .composer/cache. As we mount both directories, we cover the two possibilities.

akeneo/pim-php-dev:5.0 php /usr/local/bin/composer create-project \
akeneo/pim-community-standard /srv/pim "5.0.*@stable"

Expand Down